search

temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs
MIT License
266 stars 71 forks source link

[Feature Request] Accept float and int metrics #604

Open bergundy opened 1 year ago

bergundy commented 1 year ago

Since our goal with metrics is to expose a generic interface for metrics recording in our lang SDKs using industry standards, we should expand the metrics API in core to accept floats and not just ints.

https://github.com/temporalio/sdk-python/pull/384#discussion_r1321823495

cretz commented 1 year ago

Since our goal with metrics is to expose a generic interface for metrics recording in our lang SDKs using industry standards

I am not sure this is a goal. I think it's "expose the same interface core needs". Same in the Go SDK. There are OTel metric types we're not exposing (e.g. up/down counter). Having said that, I don't see why float shouldn't be added.