temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs
MIT License
277 stars 77 forks source link

[Bug] Local activity markers might create commands after workflow completion #659

Closed Sushisource closed 9 months ago

Sushisource commented 10 months ago

This manifests like

2023-12-14T17:56:20.923613Z  WARN temporal_sdk_core::worker::workflow: Error while completing workflow activation error=status: InvalidArgument, message: "invalid command sequence: [StartTimer, CompleteWorkflowExecution, RecordMarker], command CompleteWorkflowExecution must be the last command.", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc"} }

90% sure LAs are completing after the fact and we're adding the command when we should just be discarding it