search

temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs
MIT License
266 stars 70 forks source link

Updates for update reapply #677

Closed dandavison closed 6 months ago

dandavison commented 7 months ago

Update sdk-core to work with the new EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_REQUESTED event added in https://github.com/temporalio/api/pull/351

How this was tested

I have built sdk-python against this branch and have an in-progress server branch that demonstrates correct processing of the new update event by sdk-python: https://github.com/temporalio/temporal/pull/5361

dandavison commented 6 months ago

To be clear, this event is going to be marked worker_may_ignore correct?

Yes that's right. https://github.com/temporalio/temporal/blob/1645bea925812026397f0a5f4594e2978154b457/service/history/historybuilder/event_factory.go#L412