temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs
MIT License
266 stars 70 forks source link

Fix possibly sending LA marker after WF Complete command #678

Closed Sushisource closed 7 months ago

Sushisource commented 7 months ago

What was changed

Detect terminal commands and avoid doing anything else with LAs other than issuing cancels to outstanding ones.

Also fixed a possible shutdown hang that this surfaced.

Why?

Bugfix

Checklist

  1. Closes https://github.com/temporalio/sdk-core/issues/659

  2. How was this tested: Added unit test which repro'd issue consistently, fixed it.

  3. Any docs updates needed?