search

temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs
MIT License
262 stars 70 forks source link

Wait for activity completes to reach server before shutdown #681

Closed Sushisource closed 6 months ago

Sushisource commented 6 months ago

What was changed

Make sure we flush activity completions to server before shutting down

Why?

It's nice. We already wait for outstanding activities to complete. It makes sense to make sure we actually do something with those results.

Checklist

  1. Closes https://github.com/temporalio/sdk-core/issues/594

  2. How was this tested: Added UT

  3. Any docs updates needed?

bergundy commented 6 months ago

@mjameswh we may want to modify TS to not also wait on activity completion to be delivered to the server, need to look into this.

Definitely better done Core side.