search

temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs
MIT License
262 stars 70 forks source link

sdk: remove unnecessary Debug constraints #684

Closed djc closed 6 months ago

djc commented 6 months ago

What was changed

Removed the Debug constraint for ActExitValue and WfExitValue type parameters.

Why?

I ran into this while trying to convert some code to a Temporal activity, and was surprised by these constraints. They don't seem to actually be used by anything in the core SDK repo, so it seems safe to remove?

Checklist

  1. How was this tested: cargo check --all-targets still passes
  2. Any docs updates needed: rustdoc should take care of this
Sushisource commented 6 months ago

@djc I think this change makes sense generally, but appears to introduce some type ambiguity in some usages in integ tests:

https://github.com/temporalio/sdk-core/actions/runs/7872918589/job/21487585688?pr=684#step:9:154

You can use cargo lint to reproduce. If you resolve these and the CI jobs pass, I'm happy to merge this.

djc commented 6 months ago

Yup, will fix the inference ambiguities tomorrow, thanks!

djc commented 6 months ago

Force pushed this to fix the formatting issue.