search

temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs
MIT License
262 stars 70 forks source link

Remove lazy-static in favor of once_cell #694

Closed djc closed 6 months ago

djc commented 6 months ago

What was changed

Removed dependencies on lazy-static in favor of once_cell. Use a workspace dependency to manage the once_cell dependency in one place.

Why?

lazy-static is effectively deprecated and the ecosystem has largely moved over to once_cell. once_cell has a more ergonomic API.

Checklist

  1. How was this tested: still compiles
  2. Any docs updates needed: don't think so?
djc commented 6 months ago

Cleaned up the formatting and the missed lazy_static in the integration tests.

djc commented 6 months ago

Ugh -- what's the reason cargo check --all-targets doesn't find the integration tests? Would be nice not to require the use of custom aliases for basic checks like this.

Sushisource commented 6 months ago

Ugh -- what's the reason cargo check --all-targets doesn't find the integration tests? Would be nice not to require the use of custom aliases for basic checks like this.

There are a handful of off-by-default features and there was no simple way to get every combo of feature/target to actually test compilation all at once