Closed Sushisource closed 5 months ago
Can you confirm from a user Prometheus and OTel output POV there are no breaking changes (in labels or values or anything)?
Also before merging, which will cost a bit of time on core upgrade at least for Python and .NET, can you think of anything coming soon in SDK core that we may want to get in first?
No there are no changes to any labels or values, unless of course you choose seconds in which case the buckets are necessarily different in numerical terms, but are the same in terms of value.
There's nothing else in progress now that would matter to get in
What was changed
Support floating-point histograms to allow emitting metrics in seconds.
:boom: Breaking changes for lang :boom:
CoreMeter
interface has changed to supportf64
histograms/gauges andDuration
-accepting histogramsCoreMeter
implementations determine what units are emitted by aHistogramDuration
unit
field on the parameter is expected to be overridden by such implsMetricEvent
s used with the buffer for lang-side metrics impls have new variantsWhy?
Some people desire seconds-based latencies. Also will work OOTB with our dashboards for other langs
Checklist
Closes https://github.com/temporalio/sdk-core/issues/554
How was this tested: Added tests
Any docs updates needed?