Allow emitting duration metrics in seconds - Githubissues

temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs

MIT License

262 stars 70 forks source link

Allow emitting duration metrics in seconds #706

Closed Sushisource closed 5 months ago

Sushisource commented 5 months ago

What was changed

Support floating-point histograms to allow emitting metrics in seconds.

:boom: Breaking changes for lang :boom:

The CoreMeter interface has changed to support f64 histograms/gauges and Duration-accepting histograms
CoreMeter implementations determine what units are emitted by a HistogramDuration
- The unit field on the parameter is expected to be overridden by such impls
Correspondingly, the MetricEvents used with the buffer for lang-side metrics impls have new variants

Why?

Some people desire seconds-based latencies. Also will work OOTB with our dashboards for other langs

Checklist

Closes https://github.com/temporalio/sdk-core/issues/554
How was this tested: Added tests
Any docs updates needed?

Sushisource commented 5 months ago

Can you confirm from a user Prometheus and OTel output POV there are no breaking changes (in labels or values or anything)?

Also before merging, which will cost a bit of time on core upgrade at least for Python and .NET, can you think of anything coming soon in SDK core that we may want to get in first?

No there are no changes to any labels or values, unless of course you choose seconds in which case the buckets are necessarily different in numerical terms, but are the same in terms of value.

There's nothing else in progress now that would matter to get in