search

temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs
MIT License
250 stars 68 forks source link

client: allow public access to WorkflowHandle #724

Closed djc closed 2 months ago

djc commented 2 months ago

What was changed

As discussed in Slack, there is a basic API for awaiting workflow results from a client. Unfortunately the GetWorkflowResultOpts type that must be passed into get_workflow_result() is not exported, so this function cannot be called by SDK users.

Why?

I have a use case for awaiting the result of a workflow execution.

Checklist

  1. Closes: no issue
  2. How was this tested: untested for now
  3. Any docs updates needed: added some docstrings to newly public methods
djc commented 2 months ago

@Sushisource auto-merge isn't going to work if the unit tests are flaky...

(At least it seems very unlikely that the failure is related to my changes.)