search

temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs
MIT License
250 stars 68 forks source link

Fix request failure metric & add error code labels #739

Closed Sushisource closed 2 months ago

Sushisource commented 2 months ago

What was changed

The request failure metrics weren't actually being incremented when they should've been due to the interceptor only caring about http errors and not inspecting grpc statuses. That is fixed, and error code labels are attached w/ an option to disable.

Why?

Part of https://github.com/temporalio/features/issues/144

Checklist

  1. Closes

  2. How was this tested: Added IT

  3. Any docs updates needed?