Use Resource::default in order to respect common OTEL env vars

temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs

MIT License

250 stars 68 forks source link

Use Resource::default in order to respect common OTEL env vars #768

Closed invokermain closed 3 weeks ago

invokermain commented 3 weeks ago

What was changed

Changed the otel::default_resource function use the Resource's default trait instead of providing a single custom default attributes, which is just a fixed service name.

Why?

This makes the OTLP Exporter respect common env vars such as OTEL_RESOURCE_ATTRIBUTES, see here.

CLAassistant commented 3 weeks ago

All committers have signed the CLA.