Honor all non-terminal commands - Githubissues

temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs

MIT License

266 stars 70 forks source link

Honor all non-terminal commands #776

Closed dandavison closed 1 month ago

dandavison commented 2 months ago

Fixes #778

Previously, core was truncating commands received from lang at the first terminal command.
With this PR, if there are terminal commands, we remove them all and replace the first one at the end of the command sequence.

Evidence this is correct

unit tests added for new and old logic
TODO: add tests of replay / flag logic to core
https://github.com/temporalio/sdk-python/pull/569 uses these changes and contains tests demonstrating that update completions are now honored, even when after workflow completion.