temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs

MIT License

277 stars 77 forks source link

Don't overwrite grpc-timeout header on update requests #781

Closed dandavison closed 3 months ago

dandavison commented 3 months ago

780 caused the `sdk-python` test `tests/worker/test_workflow.py::test_workflow_update_timeout_or_cancel` to fail, because the grpc-timeout header set here was not honored:

https://github.com/temporalio/sdk-python/blob/c4b1a019ad2627edb20a954edfd57c9ba414f3d5/tests/worker/test_workflow.py#L4482

https://github.com/temporalio/sdk-python/blob/c4b1a019ad2627edb20a954edfd57c9ba414f3d5/tests/worker/test_workflow.py#L4523

@Sushisource defer to you on the correct resolution. FWIW, this PR makes the test pass again.