search

temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs
MIT License
266 stars 70 forks source link

Upgrade tonic, prost, otel to latest #782

Closed h7kanna closed 1 month ago

h7kanna commented 1 month ago

Upgrade Tonic, Prost, OTel deps

What was changed

Updated dependencies tonic - 0.12.x prost - 0.13.x otel - 0.24.x

Why?

To upgrade to hyper 1.x ecosystem

Checklist

  1. Closes #626

  2. How was this tested:

    
cargo test
cargo integ-test
To avoid mixing changes (Rust 1.80 clippy throwing lints)

cargo clippy --all -- -D warnings -A clippy::clone-on-copy



4. Any docs updates needed?
NA
h7kanna commented 1 month ago

Thanks for this! Glad the stuff is finally updated enough that everything can use the newer versions.

Looks like there is a clippy lint that needs to be fixed, and the functionality of the connection override needs to be restored.

There are lot of clippy lints about clone-with-copy unrelated to these updates, should I fix this in this PR? I can put up another separate PR along with this.

Sushisource commented 1 month ago

Thanks for this! Glad the stuff is finally updated enough that everything can use the newer versions. Looks like there is a clippy lint that needs to be fixed, and the functionality of the connection override needs to be restored.

There are lot of clippy lints about clone-with-copy unrelated to these updates, should I fix this in this PR? I can put up another separate PR along with this.

At least this one looks related, looks like the timestamp type became copyable and hence is triggering this now. If there are also other, unrelated ones, fixing them in this PR is totally fine.

h7kanna commented 1 month ago

Thanks for this! Glad the stuff is finally updated enough that everything can use the newer versions. Looks like there is a clippy lint that needs to be fixed, and the functionality of the connection override needs to be restored.

There are lot of clippy lints about clone-with-copy unrelated to these updates, should I fix this in this PR? I can put up another separate PR along with this.

At least this one looks related, looks like the timestamp type became copyable and hence is triggering this now. If there are also other, unrelated ones, fixing them in this PR is totally fine.

Done fixed