temporalio / sdk-core

Core Temporal SDK that can be used as a base for language specific Temporal SDKs
MIT License
266 stars 70 forks source link

Basic validation of activity tasks #795

Closed Sushisource closed 1 month ago

Sushisource commented 1 month ago

What was changed

At least check that activity tasks have a task token, to avoid user proxies tricking the SDK into thinking an empty poll response wasn't empty.

Why?

Custom proxy implementations breaking things.

Checklist

  1. Closes https://github.com/temporalio/sdk-core/issues/794

  2. How was this tested: Existing tests

  3. Any docs updates needed?