Closed cretz closed 2 months ago
This is annoying to use because you have to use only WaitAsync
and not with timeout and probably not even with cancellation token. And it is disposable which is confusing for workflows to implement. So while we will still keep these tests to confirm behavior, I think we're going to write our own semaphore impl.
I am closing this PR. I will be opening a separate one that contains a new Semaphore
implementation
What was changed
Added test for
SemaphoreSlim
which shows what works and what doesn'tChecklist