OnUpsertSearchAttributes and OnUpsertMemo unclear about mocking ability

[cretz]

Expected Behavior

OnUpsertSearchAttributes and OnUpsertMemo are just called when their methods are called. They were not developed to return values or return errors unlike many of our other mocks. We need to either:

• Properly document that these are essentially "event listeners" and they cannot affect behavior.
• Have these calls actually mock
  • Probably a bad idea, backwards incompat to have it override the default behavior of adding to the attr maps
  • But we could at least call this first and let the mocker return an error that is returned then to the workflow

[jPomeranz]

Just curious, was an internal consensus reached on the optimal behavior for these calls going forward? I was wondering if this is something we could make a PR for to allow the mocks or whether it's still awaiting an internal decision.

[Quinn-With-Two-Ns]

We should document that OnUpsertSearchAttributes and OnUpsertMemo are just event listeners. Mocking these calls return value in the test environment doesn't make sense since the real environment and the test environment perform identical validation so mocking would just allow users to create discrepancies between a real workflow and one running in the test environment.