temporalio / sdk-go

Temporal Go SDK
https://docs.temporal.io/application-development?lang=go
MIT License
481 stars 197 forks source link

Minor logger improovments #1495

Closed jetexe closed 1 month ago

jetexe commented 1 month ago

What was changed

  1. Move WithLogger interface close to others (same package, different file)
  2. Add skip 1 for default WithLogger implementation

Why?

  1. Moving WithLogger interface allow user to see all available interfaces in one place. It increase user experience
  2. Adding Skip function to the withLogger constructor functions allows to skip with_logger.go from the stack

Checklist

  1. How was this tested: All existing tests passed, local using replaced package
  2. Any docs updates needed? nope
CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.