search

temporalio / sdk-go

Temporal Go SDK
https://docs.temporal.io/application-development?lang=go
MIT License
481 stars 197 forks source link

Ensure our proxy helpers forward metadata #1497

Closed cretz closed 1 week ago

cretz commented 1 month ago

Describe the solution you'd like

This would be an issue for https://pkg.go.dev/go.temporal.io/api/proxy but there is no "issues" section there. Basically we need to confirm that when using the proxy library in the default way, that the headers like client-name/client-version flow through the proxy. Write a test and, if it's not flowing through, make it do so. This may just be a case of our code gen using https://pkg.go.dev/google.golang.org/grpc/metadata to populating incoming context to outgoing context (and adding an option to disable it). Probably can't have an interceptor since users control that part, we just control the service proxy helper.

cretz commented 1 month ago

PR opened at https://github.com/temporalio/api-go/pull/167 (which will be waiting for https://github.com/temporalio/sdk-go/pull/1502 to be released before merging).