Closed wuhao5 closed 3 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
What was changed
When omitting the metric "WorkflowTaskExecutionFailureCounter", there are two other occasions that don't specify the additional "failure_reason" tag. See here that omits the same metric with additional tag.
Why?
When using prometheus as a client backend, it enforces the same metric be consistent with the same tags. If not, it will generate an error, and no metric is reported.
Checklist
Closes: simple change, no issue is created.
How was this tested: Implementing a new
metrics.Handler
that is backed by Prometheus, executing an intentional failing activity or workflow, no metrics for the errors are reported.Any docs updates needed? N/A.