temporalio / sdk-go

Temporal Go SDK
https://docs.temporal.io/application-development?lang=go
MIT License
481 stars 197 forks source link

add Name method to ReceiveChannel and SendChannel interface #1538

Open bentveljanzx opened 2 days ago

bentveljanzx commented 2 days ago

What was changed

Why?

Checklist

Closes #1304

  1. How was this tested:

    • Added "TestChannelName" in internal/internal_coroutines_test.go which creates named channels and asserts that the Name method returns back the same name you gave it.
  2. Any docs updates needed?

    • N/A
CLAassistant commented 2 days ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant commented 2 days ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Quinn-With-Two-Ns commented 2 days ago

Overall LGTM, just a couple of documentation points.