Open bentveljanzx opened 2 days ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Overall LGTM, just a couple of documentation points.
What was changed
Name
method toSendChannel
andReceiveChannel
interfaceName
returns back the same given name.Why?
channel.Send
method, ideally we could simplify our API to not require a redundant sending of the channelName again.telemetrytemporal.ChannelSend[T](ctx workflow.Context, channel workflow.SendChannel, channelName string, payload T)
Checklist
Closes #1304
How was this tested:
internal/internal_coroutines_test.go
which creates named channels and asserts that theName
method returns back the same name you gave it.Any docs updates needed?