Support for WorkflowIdConflictPolicy

temporalio / sdk-go

Temporal Go SDK

https://docs.temporal.io/application-development?lang=go

MIT License

523 stars 208 forks source link

Support for WorkflowIdConflictPolicy #1563

Closed stephanos closed 2 months ago

stephanos commented 2 months ago

What was changed

Added WorkflowIdConflictPolicy to ExecuteWorkflow and SignalWithStart.

NOTE: I haven't seen any WorkflowIdReusePolicy validation inside of testsuite.WorkflowTestSuite (except for child workflows), so I didn't add any for the WorkflowIdConflictPolicy either.

Checklist

Closes https://github.com/temporalio/sdk-go/issues/1447

cretz commented 2 months ago

@stephanos - can you also make sure this is added for ScheduleWorkflowAction?

stephanos commented 2 months ago

@cretz I might be missing something, but when I looked at the schedule code I saw it's not using StartWorkflowOptions anywhere and therefore doesn't have either WorkflowIdReusePolicy or WorkflowIdConflictPolicy fields?

cretz commented 2 months ago

My mistake, this is not needed, I was confusing with languages that reused common sets of start options.