search

temporalio / sdk-java

Temporal Java SDK
https://temporal.io
Apache License 2.0
218 stars 146 forks source link

Support Java Modules #1940

Open Quinn-With-Two-Ns opened 11 months ago

Quinn-With-Two-Ns commented 11 months ago

Is your feature request related to a problem? Please describe. Support Java Modules

Describe the solution you'd like Every relevant library should publish a Automatic-Module-Name in the manifest or a module-info.java. Currently the Java SDK cannot be used as a named Java module since some of modules implement the same packages.

error: the unnamed module reads package io.temporal.internal.common from both temporal.sdk and temporal.serviceclient
error: the unnamed module reads package io.temporal.internal from both temporal.sdk and temporal.serviceclient

Java modules do not allow this, it is called a split package.

Describe alternatives you've considered Don't support Jave modules

Riva2006 commented 10 months ago

It is important fix to all Java developers , Currently we using shadow to repack the packages , It is important to get basic support of module-info

dbiere commented 2 weeks ago

This issue was opened nearly a year ago and is still a problem as of Temporal Java SDK 1.24.1. Is this on the roadmap to resolve? Thank you.

Quinn-With-Two-Ns commented 2 weeks ago

Yes we are aware of this issue, but I have no timeline on when this will be resolved.