search

temporalio / sdk-java

Temporal Java SDK
https://temporal.io
Apache License 2.0
200 stars 134 forks source link

Add ScheduleClientInterceptor APIs (fixes #2048) #2050

Closed dano closed 2 months ago

dano commented 2 months ago

What was changed

This adds APIs for users to specify interceptors when creating a ScheduleClient. Previously there was interceptor infrastructure built into the internals of the client, but no public API to allow users to actually add them.

Why?

So that users can add interceptors as needed.

Checklist

  1. Closes #2048

  2. How was this tested: Unit tests

  3. Any docs updates needed? Not sure. The current docs don't talk about how ScheduleClient is created right now, so probably not?

Quinn-With-Two-Ns commented 2 months ago

Thanks for the contribution! I think we just need a base implementation like other interceptors and we are good to merge

dano commented 2 months ago

Unit test issue is fixed now.