temporalio / sdk-java

Temporal Java SDK
https://temporal.io
Apache License 2.0
200 stars 134 forks source link

Don't return update handles until desired stage reached #2066

Closed Sushisource closed 1 month ago

Sushisource commented 1 month ago

What was changed

Why?

See https://github.com/temporalio/features/issues/432

Checklist

  1. Closes https://github.com/temporalio/sdk-java/issues/2002

  2. How was this tested: Existing / new tests

  3. Any docs updates needed?

Quinn-With-Two-Ns commented 1 month ago

While we are refactoring this area could we also do https://github.com/temporalio/sdk-java/issues/2045? I believe @cretz did this in python by requiring a wait stage be passed? If not I'll do it in a follow up PR.

Quinn-With-Two-Ns commented 1 month ago

Don't we also need to update the test server to return the updates current lifecycle state? or does the test server never actually return an empty response?

Sushisource commented 1 month ago

Don't we also need to update the test server to return the updates current lifecycle state? or does the test server never actually return an empty response?

I have changed it to do so - here for example https://github.com/temporalio/sdk-java/pull/2066/files#diff-809c076b3ee441df02cf0c4566a20f7abc69c94c15d8b689875350ae3fcdbfd9R1808