Closed rorueda closed 4 months ago
This is already fixed by https://github.com/temporalio/sdk-java/commit/a41c64ece3876f584ebde70903668b817c5455d8 and will be included in the next SDK release
I can't rule out my test being wrong, but I have just tested on top of the current last commit https://github.com/temporalio/sdk-java/commit/5e5cf0bf2db695cba46d1855959e02b4cdfa3cff and it still fails. Any idea why?
hm let me try to get your test running on my machine
Expected Behavior
Querying a workflow doesn't generate additional logs.
Actual Behavior
Querying a workflow generates additional logs.
Steps to Reproduce the Problem
I added an additional test to
DirectQueryReplaysDontSpamLogWithWorkflowExecutionExceptionsTest.java
to reproduce the issue.I found that the logs are generated because replaying is being set to false here: https://github.com/temporalio/sdk-java/blob/5e5cf0bf2db695cba46d1855959e02b4cdfa3cff/temporal-sdk/src/main/java/io/temporal/internal/statemachines/WorkflowStateMachines.java#L456-L462
I saw that there were changes to those lines recently, but I've tested with 1.23.1, 1.23.2 and master and the issue is present in all of them. I first noticed the issue in production when upgrading from 1.19.1 to 1.23.1.
Specifications