Add deterministic alternatives for asyncio.wait and asyncio.as_completed

temporalio / sdk-python

Temporal Python SDK

MIT License

473 stars 77 forks source link

Add deterministic alternatives for asyncio.wait and asyncio.as_completed #533

Closed cretz closed 6 months ago

cretz commented 6 months ago

What was changed

asyncio.as_completed and asyncio.wait are non-deterministic sometimes so we need alternatives.

Created deterministic workflow.as_completed and workflow.wait alternatives
Updated the README to encourage their use
Issue warnings when the asyncio ones are called (to become errors in #535 in the future)

Checklist

Closes #429
Closes #518

cretz commented 6 months ago

After team discussion, it was decided to issue warnings if the asyncio versions are called. The PR has been updated to support this. Please re-review.