Closed dandavison closed 5 months ago
This PR was missing one thing -- it didn't address cancellation. Discussed with @cretz in a different channel and we agreed that it was a bug that the CancelWorkflowExecution
command was not being defined to be a workflow "completion" by the SDK. Recent commits fix that bug and add the test coverage that this PR had been missing regarding cancellation.
Closes #538
Implementation ready for review; names are still under discussion.
What was changed
workflow.all_handlers_finished()
.Why?
Workflows exiting while handler executions are in progress is an important category of run-time workflow incorrectness.