search

temporalio / sdk-ruby

Temporal Ruby SDK
MIT License
74 stars 7 forks source link

Set client identity and build version #81

Closed laertispappas closed 4 months ago

laertispappas commented 2 years ago

Extract identity, build id and client information from bridge to Ruby scope.

NOTE: It would be great if we could pass the rust xConfig object directly but it looks like Rutie does not support it out of the box unless you implement a couple of interfaces. Other option would be to add https://github.com/deliveroo/rutie-serde but that would be another dependency on top.

laertispappas commented 2 years ago

Hi @antstorm, @cretz can I have your eyes on this PR? Are you okay if I proceed and finalize this PR for review? Changeset will include the config options to be injected and implement: identity, client_name and client_version. build id will be on a follow up PR.

Thank you in advance.

laertispappas commented 1 year ago

@Sushisource Thank you for your input. I have removed the redundant "middle" structs in favor of the core ones.

cretz commented 1 year ago

I will defer to @antstorm here. This repo is under heavy active development and I am not sure how this contribution fits into the plan (we of course always want contributions, just want to make sure he doesn't have alternative designs for this feature).

laertispappas commented 1 year ago

@cretz Thank you for your input I understand will wait for feedback from @antstorm

laertispappas commented 1 year ago

HI @antstorm Thank you for the feedback. I pushed some changes on top.

cretz commented 4 months ago

The SDK is undergoing a rewrite/refresh and this PR applied to a previous version and is no longer applicable