search

temporalio / sdk-typescript

Temporal TypeScript SDK
Other
519 stars 103 forks source link

[Bug] Comment unclear on when activities are cancelled after calling `Worker.shutdown` #1309

Open bergundy opened 9 months ago

bergundy commented 9 months ago

It should mention that the activities are cancelled after shutdownGraceTime.

https://github.com/temporalio/sdk-typescript/blob/28d4de33a2697c949b863d1c541063384c4fcc7c/packages/worker/src/worker.ts#L733

gaurava05 commented 9 months ago

Can I pick this up? I am new to this repo, let me know where I should start.

lorensr commented 9 months ago

@gaurav7019 sure, thanks—you can submit a PR that edits the comment linked to above

nikhilbhatia08 commented 1 day ago

@lorensr I would like to submit a PR that edits the comment