search

temporalio / tcld

The temporal cloud cli.
MIT License
32 stars 18 forks source link

feat: add api key owner listing flag #397

Open gabizou opened 6 days ago

gabizou commented 6 days ago

What was changed

This adds the --owner-id flag to the tcld ak l command, with a shorthand of -oid.

Why?

Given that this will enable passing in ServiceAccount IDs or User IDs, we can better reduce the number of paginated requests being performed for automations that are centered around key rotations, while enabling continued development

Checklist

  1. Closes #395

  2. How was this tested:

    I built the command locally and ran it against our cloud instance to great success.

  3. Any docs updates needed?

    Updated the README for listing API keys and also took liberty to document rotating ServiceAccount keys in the same manner (since the --si value flag was undocumented in README).

shakeelrao commented 6 days ago

looks great -- thanks for the contribution!

will have another colleague review before landing.