tctl workflow start and workflow signal commands do not encrypt input parameters using data converter - Githubissues

temporalio / tctl

Temporal CLI

https://docs.temporal.io/docs/system-tools/tctl

MIT License

43 stars 35 forks source link

tctl workflow start and workflow signal commands do not encrypt input parameters using data converter #137

Open postermann-indeed opened 2 years ago

postermann-indeed commented 2 years ago

What are you really trying to do?

I'm attempting to encrypt data sent to Temporal via the CLI.

Describe the bug

When running workflow start and workflow signal commands in tctl, the input parameters are not encoded via the configured plugin data converter.

Minimal Reproduction

This is reproducible using the samples-go/encryption plugin:

Build the encryption plugin and start the worker as described in the samples-go/encryption readme

Run the following command:

export PATH="../bin:$PATH" TEMPORAL_CLI_PLUGIN_DATA_CONVERTER=encryption-plugin
tctl workflow start --tq encryption --wt Workflow -i '"My Secret Friend"'

Open the Temporal WebUI, and navigate to the new workflow
Note that the input is not encrypted

Environment/Versions

OS and processor: macOS Big Sur 11.6, i9
Temporal Version: 1.14.1
Tested locally using the docker-compose files

robholland commented 2 years ago

Unfortunately the plugin system we are using does not allow us to implement this with the current setup. Only decoding is supported by tctl for now. We are working on ways of giving tctl full support for data conversion but there is not a timeline for having that working as yet.