temporalio / temporal-learning

temporal-learning.preview.thundergun.io
Other
3 stars 7 forks source link

EDU-2685: Removes Gradle coverage from Java Hello World #267

Closed fairlydurable closed 4 months ago

fairlydurable commented 4 months ago
vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
temporal-learning ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 6:43pm
axfelix commented 4 months ago

Looks good! I had to make a minor additional change in pom.xml to get it compiling on Windows (bumping a couple instances of 1.7 to 1.8, with maven 3.9.8 and Java 21), but I don't know how reproducible those are, so I'm stamping :)

fairlydurable commented 4 months ago

Note for the future: @MasonEgger also kindly renamed maven on the code repo to main, replacing master as the default branch.