search

temporalio / temporal-learning

temporal-learning.preview.thundergun.io
Other
3 stars 7 forks source link

EDU-2686: Revert updates to align with Python and dotNet. #272

Closed fairlydurable closed 3 months ago

fairlydurable commented 3 months ago

Hi all.

When reviewing this document, the goal is not to "improve" it for anything beyond finding obvious errors. This patch brings this material into sync with dotNet and Python with the least content that differs from those sources.

I coordinated this effort with Brian.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
temporal-learning ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 8:39pm
axfelix commented 3 months ago

This looks like a very close match to me and is very legible to a beginner! My only real question is whether we need the whole mvn clean install on every execution -- I know that doing something like mvn clean compile && mvn exec:java -Dexec.mainClass="class" isn't too much simpler, but I don't really know what people's expectations of CLI Java are.