search

temporalio / temporal

Temporal service
https://docs.temporal.io
MIT License
11.73k stars 830 forks source link

[Bug] Version info upgrade notification does not get cleared after cluster version upgrade #4094

Open bergundy opened 1 year ago

bergundy commented 1 year ago

Sample output from tctl admin cluster describe:

"versionInfo": {
  "current": {
   "version": "1.20.0",
   "releaseTime": "2023-02-17T21:48:00Z"
  },
  "recommended": {
   "version": "1.20.0",
   "releaseTime": "2023-02-17T21:48:00Z"
  },
  "alerts": [
   {
    "message": ":ringed_planet: A new release is available!",
    "severity": "Low"
   }
  ],
  "lastUpdateTime": "2023-03-22T08:54:54.838392383Z"
 }

Note that the lastUpdateTime is after the cluster was upgraded.

smcgivern commented 1 year ago

We're seeing something similar:

{
  "supportedClients": {
    "temporal-cli": "\u003c2.0.0",
    "temporal-go": "\u003c2.0.0",
    "temporal-java": "\u003c2.0.0",
    "temporal-php": "\u003c2.0.0",
    "temporal-server": "\u003c2.0.0",
    "temporal-typescript": "\u003c2.0.0",
    "temporal-ui": "\u003c3.0.0"
  },
  "serverVersion": "1.22.0",
  // snip
  "versionInfo": {
    "current": {
      "version": "1.20.3",
      "releaseTime": "2023-05-16T04:25:00Z"
    },
    "recommended": {
      "version": "1.21.2",
      "releaseTime": "2023-07-15T02:00:00Z"
    },
    "alerts": [
      {
        "message": "🪐 A new release is available!",
        "severity": "Low"
      }
    ],
    "lastUpdateTime": "2023-09-08T14:24:09.898917704Z"
  },
  "failoverVersionIncrement": "10",
  "initialFailoverVersion": "1"
}

Per https://community.temporal.io/t/cluster-upgrade-from-1-14-4-1-9-0-serverversion-changes-but-current-version-stays-1-14-4/6691/2, we should consider serverVersion to be accurate, but the cluster's versionInfo hasn't updated, which is confusing.