search

temporalio / temporal

Temporal service
https://docs.temporal.io
MIT License
10.57k stars 769 forks source link

Cannot load archived (s3 provider) workflow history on UI #6193

Open gootik opened 5 days ago

gootik commented 5 days ago

From my basic research (with no real context into the code) it seems like DescribeWorkflowExecution in frontend workflow_handler does not take into account that a workflow can be archived. In which case it needs to do special logic.

GetWorkflowExecutionHistory on the other hand, handles archived workflows perfectly.

This results in the UI not being able to show workflow run page because describe request fails with 404.

Expected Behavior

Be able to open a workflow run from Archived page and get the detailed history for history archival.

Actual Behavior

404 on openning the page.

Steps to Reproduce the Problem

  1. Create a namespace with short retention and archival s3 enabled
  2. run a workflow and let archival happen
  3. let retention time pass
  4. try to open workflow from Archived UI page

Specifications

gootik commented 3 days ago

Looks like this is a duplicate of the following: https://github.com/temporalio/ui/issues/1174 https://github.com/temporalio/ui/issues/1702

and an attempt to fix https://github.com/temporalio/temporal/pull/5117