search

temporalio / terraform-provider-temporalcloud

Terraform provider for Temporal Cloud
Mozilla Public License 2.0
11 stars 9 forks source link

Add account metrics resource #94

Open ennyjfrick opened 5 months ago

ennyjfrick commented 5 months ago

What was changed

Hi again! This PR adds a new resource to configure account-level metrics. It allows enabling and disabling of an account's metrics endpoint, configuring the CA cert accepted by the metrics endpoint, and exporting the metrics endpoint URI once created.

Why?

The new resource is intended to enable a better experience for operators with certificate and observability infrastructure already in Terraform. Instead of needing to configure certificates and Prometheus scrapes for Temporal Cloud out-of-band, Temporal Cloud observability features can now slot nicely in with existing Terraform configuration.

Checklist

  1. How was this tested: Run acceptance tests

  2. Any docs updates needed? Docs generated!

swgillespie commented 5 months ago

thank you for all of the hard work on these 🙏 I will check this out!

anekkanti commented 5 months ago

@ennyjfrick thank you for your PR.

The protos/apis you are referring from the tcld repo are meant to be deprecated, and will be replaced by the once in api-cloud repo. We have a proposed account metrics mgmt apis that we are working on. PR:https://github.com/temporalio/api-cloud/pull/14. We hope to get this out soon. Can we hold off on this PR and wait for the apis to be available?

ennyjfrick commented 5 months ago

@anekkanti totally fine with me!

ennyjfrick commented 4 months ago

@anekkanti hey! wondering if there was any update on the updated account management APIs

swgillespie commented 2 months ago

@anekkanti can you share any updates you have here?

anekkanti commented 1 month ago

@ennyjfrick @swgillespie We finally have a path to unblock the above APIs, and i am working on it. It will likely take us at least a few weeks to get the required APIs out for metrics mgmt.