search

temporalio / ui

Temporal UI
https://docs.temporal.io/web-ui
MIT License
193 stars 70 forks source link

Can't display archived workflows history which have past the retention #1702

Open Aoao54 opened 1 year ago

Aoao54 commented 1 year ago

Describe the bug Can't display archived workflows history which have past the retention.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'web-UI'
  2. Click on 'archive'
  3. Click a workflow which has past the retention
  4. See 404 error

Expected behavior Display archived workflows history which have past the retention from archived file store S3.

Screenshots

image

Desktop (please complete the following information):

Additional context

History for archived workflows can be retrieved from archival storage and returned via the GetWorkflowExecutionHistory API or tctl wf show when runID is specified.

But on the web-ui , Only archived workflows that do not exceed the retention can be displayed normally. I guess there is an API mistake here.

EricxStone commented 2 months ago

Hi, may I know if any fix has been working on? I saw that there was an attempt in the Temporal side but I agree that the fix should be done on the UI.

I found in the service.proto that there is an API called ListArchivedWorkflowExecutions. I am wondering if we are missing this that cause the 404 issue.

Because I try to trace in the code, looks like the 404 is given in src/routes/(app)/namespaces/[namespace]/workflows/[workflow]/page.ts. The load function is calling fetchWorkflowForRunId method which is calling ListWorkflowExecutions which I am not sure if it would includes archived workflow. If it cannot find the run ID, it will return 404. I might be wrong as I am not an expert in Svelte.