temporalio / vscode-debugger-extension

Visual Studio Code debugger plugin
https://marketplace.visualstudio.com/items?itemName=temporal-technologies.temporalio
MIT License
19 stars 8 forks source link

Update UI #18

Closed laurakwhit closed 2 years ago

laurakwhit commented 2 years ago

What was changed

This PR fixes/updates the UI in the extension webview with the use of the Webview UI Toolkit for Visual Studio Code and Visual Studio Code icons via svelte-codicons.

Before After (Dark) After (Light)
Screen Shot 2022-09-29 at 1 48 46 PM Screen Shot 2022-09-29 at 1 36 46 PM Screen Shot 2022-09-29 at 1 38 46 PM
Screen Shot 2022-09-29 at 1 48 54 PM Screen Shot 2022-09-29 at 1 36 59 PM Screen Shot 2022-09-29 at 1 38 58 PM
Screen Shot 2022-09-29 at 1 48 33 PM Screen Shot 2022-09-29 at 1 37 44 PM Screen Shot 2022-09-29 at 1 38 14 PM
CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

bergundy commented 2 years ago

Looks like now if I try to debug a workflow the second time, the tab doesn't switch to the history view.

bergundy commented 2 years ago

Yup, history is not refreshed.

bergundy commented 2 years ago

For some reason, sometimes when I click on the "choose file" button nothing happens now, can't reliably reproduce this.

laurakwhit commented 2 years ago

Looks like now if I try to debug a workflow the second time, the tab doesn't switch to the history view. Yup, history is not refreshed.

@bergundy thanks for the feedback! I've made some updates, including a fix for ☝️

For some reason, sometimes when I click on the "choose file" button nothing happens now, can't reliably reproduce this.

I couldn't reproduce, but let me know if you encounter it again. Wondering if there's something off with a click or submit event handler somewhere 🤔

laurakwhit commented 2 years ago

The file inputs don't work for me

@bergundy is finder not opening? Or is it another issue? I'm unable to reproduce and would like to get to the bottom of any issues before merging 😅

bergundy commented 2 years ago

Yeah, finder is not opening. Didn’t dig deeper. I’ll try to get info from the dev console.

bergundy commented 2 years ago

2 things:

  1. I don't know why I'm working now
  2. I upgraded vscode and it resolved the issue 🤷