search

temporalio / vscode-debugger-extension

Visual Studio Code debugger plugin
https://marketplace.visualstudio.com/items?itemName=temporal-technologies.temporalio
MIT License
19 stars 7 forks source link

[Fix] Event handlers are not properly deregistered #22

Closed laurakwhit closed 1 year ago

laurakwhit commented 1 year ago

What was changed

Why?

Addresses some of the TODO comments in the code.

Checklist

  1. Closes https://github.com/temporalio/vscode-debugger-plugin/issues/21

  2. How was this tested: TBD

  3. Any docs updates needed? n/a

laurakwhit commented 1 year ago

@bergundy I've made a few updates based on your comments. If there are still things that need to be addressed I'll open up a follow-up PR.

bergundy commented 1 year ago

I checked the 2 commits you pushed, they're not what I had in mind. Let's sync on this.