temyers / cucumber-jvm-parallel-plugin

Maven plugin to help running Cucumber features in parallel
Apache License 2.0
129 stars 121 forks source link

Added failing test for issue 150 #151

Closed froemra closed 6 years ago

froemra commented 7 years ago

Its a copy of simple-it, only feature1.feature was changed, so it uses the #language-tag. In this case "de" for german. The Gherkin-Keywords were modified accordingly. It should create 2 runners, but fails parsing the german feature.

mpkorstanje commented 7 years ago

The build fails on checkstyle. @temyers?

froemra commented 7 years ago

the same thing happens when i build the clean repo locally, had to comment that section out from maven pom ...

Am 14.11.2017 um 17:35 schrieb M.P. Korstanje notifications@github.com:

The build fails on checkstyle. @temyers https://github.com/temyers?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/temyers/cucumber-jvm-parallel-plugin/pull/151#issuecomment-344316895, or mute the thread https://github.com/notifications/unsubscribe-auth/Af7c3Pp0OdL3bL9P3wvzhfCsxaUE2sEYks5s2cE1gaJpZM4Qc9J9.

temyers commented 7 years ago

Hmm,

Looks like a Checkstyle property was removed in Checkstyle 8.2

http://checkstyle.sourceforge.net/releasenotes.html

remove deprecated property maxLineLength from LeftCurlyCheck. Author: rnveach #3671

The checkstyle report version is currently set to:

<dependencies>
                    <dependency>
                        <groupId>com.puppycrawl.tools</groupId>
                        <artifactId>checkstyle</artifactId>
                        <version>LATEST</version>
                    </dependency>
                </dependencies>

I'll remove the failing config.

temyers commented 7 years ago

Fixed in 2efd26584d3bf518ead7f34b06430a9b8f589fc5

mpkorstanje commented 6 years ago

@froemra you should be able to rebase against master now.

froemra commented 6 years ago

thank, you. rebase is done.

Am 21.11.2017 um 23:55 schrieb M.P. Korstanje notifications@github.com:

@froemra https://github.com/froemra you should be able to rebase against master now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/temyers/cucumber-jvm-parallel-plugin/pull/151#issuecomment-346188304, or mute the thread https://github.com/notifications/unsubscribe-auth/Af7c3N34gwsfbQWiNo1u28yuJAvTf2QZks5s41TNgaJpZM4Qc9J9.

mpkorstanje commented 6 years ago

The build doesn't fail. Are you reproducing the problem correctly?

froemra commented 6 years ago

Tried it today: It fails at my PC at work. It does NOT fail on my private System at home … Seems this is a configuration issue, I’ll have a closer look at it next week and will give feedback.

Am 28.11.2017 um 15:11 schrieb M.P. Korstanje notifications@github.com:

The build doesn't fail. Are you reproducing the problem correctly?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/temyers/cucumber-jvm-parallel-plugin/pull/151#issuecomment-347534702, or mute the thread https://github.com/notifications/unsubscribe-auth/Af7c3EOfeQ26-JkT_yQ6B4AFZQVUV5owks5s7BSDgaJpZM4Qc9J9.

froemra commented 6 years ago

Thanks for your help on the issue. Closing the pull request now, because this seems to be local problem on my dev environment. I cannot reproduce it on GitHub.