search

ten-point-nine / freETarget

Electronic Air Rifle Target
86 stars 44 forks source link

Typo mismatch #36

Open rsamanez opened 1 month ago

rsamanez commented 1 month ago

Hi, Actually, I'm not sure if this is a typo or the code was modified for some reason. It's in the Arduino software, in the "freeETarget.ino" file, in the arm() implementation function, line 380

if ( sensor_status & TRIP_EAST )

I think it should be changed with

if ( sensor_status & TRIP_NORTH )
ten-point-nine commented 1 month ago

Thank you I’ll look into it.

Did it cause an error, or how did you find it?

Thanks

Allan

On Sep 24, 2024, at 1:06 PM, Rommel Samanez @.***> wrote:

Hi, Actually, I'm not sure if this is a typo or the code was modified for some reason. It's in the Arduino software, in the "freeETarget.ino" file, in the arm() implementation function, line 380

if ( sensor_status & TRIP_EAST ) I think it should be changed with

if ( sensor_status & TRIP_NORTH ) — Reply to this email directly, view it on GitHub https://github.com/ten-point-nine/freETarget/issues/36, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOCD5LP2DMYRZP5X2KMCOZLZYGS3LAVCNFSM6AAAAABOY3NFZOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2DMMBTGQ4TONI. You are receiving this because you are subscribed to this thread.

ten-point-nine commented 1 month ago

You are correct it is a typo.Fortunately it doesn’t affect the normal operation of the target.I’ll see if it was copied to Version 5ThanksAllanSent from my iPhoneOn Sep 24, 2024, at 13:06, Rommel Samanez @.***> wrote: Hi, Actually, I'm not sure if this is a typo or the code was modified for some reason. It's in the Arduino software, in the "freeETarget.ino" file, in the arm() implementation function, line 380 if ( sensor_status & TRIP_EAST )

I think it should be changed with if ( sensor_status & TRIP_NORTH )

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

ten-point-nine commented 1 month ago

ThanksI checked version 5 and that portion does the test a different way, so the bug was not propagated AllanSent from my iPhoneOn Sep 24, 2024, at 13:31, Allan Brown @.> wrote:Thank you I’ll look into it.Did it cause an error, or how did you find it?ThanksAllanOn Sep 24, 2024, at 1:06 PM, Rommel Samanez @.> wrote:Hi, Actually, I'm not sure if this is a typo or the code was modified for some reason. It's in the Arduino software, in the "freeETarget.ino" file, in the arm() implementation function, line 380 if ( sensor_status & TRIP_EAST ) I think it should be changed with if ( sensor_status & TRIP_NORTH ) —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>