search

ten1seven / what-input

A global utility for tracking the current input method (mouse/pointer, keyboard or touch).
https://ten1seven.github.io/what-input
MIT License
1.35k stars 89 forks source link

Firefox: Permission denied to access property "type" #96

Open candymac opened 5 years ago

candymac commented 5 years ago

Sentry has been reporting an issue specific to Firefox: Permission denied to access property "type" on line 296 of dist/what-input.js - it is specific to Firefox across various platforms but seems intermittent.

Screen Shot 2019-06-18 at 5 12 51 PM

Also thought I'd mention some users on Firefox for FireTV are reporting an issue that seems to be consistent with the browser reporting 'mouse' as the current input device, but this might not be related (or perhaps though not technically a mouse this is correct, though it breaks some functionality in our case).

ten1seven commented 5 years ago

Thanks @candymac. What version are you using?

candymac commented 5 years ago

Thanks for quick reply. Looks like we're on v5.2.1 - I see there have been a few subsequent updates.

ten1seven commented 5 years ago

There has, but the line you're referring to does still exist here https://github.com/ten1seven/what-input/blob/master/src/scripts/what-input.js#L244

However, some of the updates had to do with mouse event handling. Would you be up for testing out the current version to see if the issue is still there? If so, I'm happy to dig into it.

Is your app public facing if I were to pull it up in Firefox for FireTV for testing?

candymac commented 5 years ago

We went ahead and upgraded. I'll circle back in the next week and let you know if the reports persist. Also, I haven't independently verified the issues on FireTV... I'll do so first, to try to rule out any issues with our code. Stay Tuned.

ten1seven commented 5 years ago

FireTV "stay tuned" 🥁

candymac commented 5 years ago

Hi, just wanted to follow up. So it appears the FireTV issue was unrelated to what-input, but thanks for offer to test it out. We do however continue to get the same report sporadically on Sentry after upgrading ... we've been unable to reproduce it ourselves and unclear what conditions might cause it to occur, or if it even adversely effects functionality.

danf1024 commented 4 years ago

also seeing the same issue with 5.2.3 and Firefox