search

ten3roberts / flax

Batteries included ECS library for rust with entity relations and much more
78 stars 5 forks source link

chore!: remove `removed` filter #14

Closed ten3roberts closed 1 year ago

ten3roberts commented 1 year ago

Component removals for entities is error prone as it only tracks entities which are still alive and they quickly fall prone to pitfalls when used inside queries.

Use the subscription mechanism instead, which will also allow you to store the value of the removed component

Additionally, this removes a lot of bookkeeping and memory overhead for things you rarely paid for

codecov-commenter commented 1 year ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7f72f51) 75.65% compared to head (149eaf2) 75.66%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #14 +/- ## ========================================== + Coverage 75.65% 75.66% +0.01% ========================================== Files 69 70 +1 Lines 5335 5301 -34 ========================================== - Hits 4036 4011 -25 + Misses 1299 1290 -9 ``` | [Files](https://app.codecov.io/gh/ten3roberts/flax/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts) | Coverage Δ | | |---|---|---| | [src/archetype/changes.rs](https://app.codecov.io/gh/ten3roberts/flax/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts#diff-c3JjL2FyY2hldHlwZS9jaGFuZ2VzLnJz) | `90.95% <ø> (+0.90%)` | :arrow_up: | | [src/archetype/guard.rs](https://app.codecov.io/gh/ten3roberts/flax/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts#diff-c3JjL2FyY2hldHlwZS9ndWFyZC5ycw==) | `68.18% <100.00%> (-0.57%)` | :arrow_down: | | [src/archetype/mod.rs](https://app.codecov.io/gh/ten3roberts/flax/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts#diff-c3JjL2FyY2hldHlwZS9tb2QucnM=) | `85.76% <100.00%> (-1.74%)` | :arrow_down: | | [src/component.rs](https://app.codecov.io/gh/ten3roberts/flax/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts#diff-c3JjL2NvbXBvbmVudC5ycw==) | `63.07% <ø> (-0.56%)` | :arrow_down: | | [src/fetch/ext.rs](https://app.codecov.io/gh/ten3roberts/flax/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts#diff-c3JjL2ZldGNoL2V4dC5ycw==) | `90.47% <ø> (ø)` | | | [src/filter/change.rs](https://app.codecov.io/gh/ten3roberts/flax/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts#diff-c3JjL2ZpbHRlci9jaGFuZ2UucnM=) | `79.66% <100.00%> (+4.10%)` | :arrow_up: | | [src/filter/mod.rs](https://app.codecov.io/gh/ten3roberts/flax/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts#diff-c3JjL2ZpbHRlci9tb2QucnM=) | `63.44% <ø> (ø)` | | | [src/metadata/relation.rs](https://app.codecov.io/gh/ten3roberts/flax/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts#diff-c3JjL21ldGFkYXRhL3JlbGF0aW9uLnJz) | `100.00% <ø> (ø)` | | | [src/world.rs](https://app.codecov.io/gh/ten3roberts/flax/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts#diff-c3JjL3dvcmxkLnJz) | `88.77% <100.00%> (-0.14%)` | :arrow_down: | | [src/writer.rs](https://app.codecov.io/gh/ten3roberts/flax/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts#diff-c3JjL3dyaXRlci5ycw==) | `79.72% <100.00%> (+0.40%)` | :arrow_up: | | ... and [2 more](https://app.codecov.io/gh/ten3roberts/flax/pull/14?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/ten3roberts/flax/pull/14/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tei+Leelo+Roberts)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.