tenable / Tenable.io-SDK-for-Python

Tenable.io SDK offers a scalable and safe way to integrate with the Tenable.io platform.
MIT License
83 stars 35 forks source link

Test Refactor #123

Closed tenableAndrew closed 5 years ago

tenableAndrew commented 5 years ago

The purpose of this PR is to improve test quality, performance, and stability in the SDK.

Currently the SDK tests rely on a live environment with a correctly configured account. This is necessary so that tests can make the required HTTP requests against the tenable.io API. However, it also causes tests to be non-deterministic, run slowly, and likely be unaccessible to potential contributors.

This change would transition the SDK to utilize the pytest-vcr to eliminate HTTP requests from the tests themselves, having all tests will run against pre-recorded HTTP requests/responses in the form of cassette files.

In addition to that, this change also adds roughly 30 new tests to cover areas of the SDK that had lacking coverage.

This change should have no impact on SDK functionality and does not warrant a user release.