search

tenacityteam / tenacity-legacy

THIS REPO IS NOT MAINTAINED ANYMORE. Please see https://codeberg.org/tenacityteam/tenacity for Tenacity, which is maintained.
https://tenacityaudio.org
Other
6.77k stars 256 forks source link

Tenacity renaming in macOS manifest #632

Closed Mondanzo closed 3 years ago

Mondanzo commented 3 years ago

Removes all mentions of Audacity from the MacOS Manifest file

Resolves: #618

Checklist - [x] I have signed off my commits using `-s` or `Signed-off-by`\* (See: [Contributing § DCO](https://github.com/tenacityteam/tenacity/blob/master/CONTRIBUTING.md#developer-certificate-of-origin)) - [ ] I made sure the code compiles on my machine - [x] I made sure there are no unnecessary changes in the code\* - [x] I made sure the title of the PR reflects the core meaning of the issue you are solving\* - [x] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"\* \* indicates required
n0toose commented 3 years ago

We'll discuss the MIME type association a bit further internally, but this should be good to go for now.

nbsp commented 3 years ago

Make sure to squash when merging, or just fixup the two commits.

nbsp commented 3 years ago

Something happened with the tree; duped diffs and an empty merge commit. Should be fixed now.

n0toose commented 3 years ago

Considering that it's been over 12 hours and the issue you brought up has been resolved, can we merge this?

nbsp commented 3 years ago

As long as it's been tested on macOS, sure.

n0toose commented 3 years ago

Successfully tested on Catalina.