It is no longer possible to record computer audio starting with a particular Tenacity build

Greg-21 commented 3 years ago

Guidelines

[X] I have read the guidelines.

Version/Commit hash

eb774a449c6fec354c06d8fcc33ca8007664e8e8

Describe the bug.

Launch Tenacity.
Open Tenacity settings (e.g. by clicking: Edit > Preferences...), and go to "Devices" category.
Set the host interface to "Windows WASAPI".
Try to set the recording device to speakers/headphones to loop back computer audio for recording.
See what is described in the "Actual behavior" section.

Actual behavior

Only the microphone appears on the list, the speakers/headphones do not, as well as a few other devices, making it impossible to record computer audio using newer Tenacity builds.

Screenshot showing how it "works" (or actually does not) in newer Tenacity builds:

Tenacity-ebd31bb-and-later As you can see in the screenshot above, in newer Tenacity builds, only the microphone ("mikrofon" in my OS language) appears on the list, making it impossible to record computer audio.

Expected behavior

At least the speakers/headphones should also appear on the list as one of the available recording devices, as they did in older Tenacity builds.

Screenshot showing how it worked in older Tenacity builds, and how I expect it to work now as well:

Tenacity-4e877b8-and-before As you can see in the screenshot above, in older Tenacity builds, the speakers ("głośniki" in my OS language), as well as a few other devices, all appeared on the list. This is how I expect it to work now as well.

OS

Windows

Additional context

This is something that broke between:

the Tenacity build based on commit 4e877b8aed62d3318212e1a863b1c0212787bede (this is the last good one)
the one based on ebd31bb3762f5e5c11b9a8fe5e3fb8f059c10ebe (this is the first bad one).

This issue is not a duplicate

[X] I have confirmed this issue isn't a duplicate.

Be-ing commented 3 years ago

This seems to be a regression in PortAudio. Please report the bug upstream: https://github.com/PortAudio/portaudio/issues

crsib commented 3 years ago

It is not. I will send the required patch upstream after 3.1 release

Be-ing commented 3 years ago

Oh, right, I forgot about that patch in the old vendored PortAudio fork for loopback devices.

I will send the required patch upstream after 3.1 release

I encourage you to open the pull request upstream now even if you don't currently have time to respond to review comments. It often takes a while before the PortAudio maintainers get around to reviewing pull requests.

Be-ing commented 3 years ago

Please report the bug upstream

Nevermind, please do not do that.

Greg-21 commented 2 years ago

@crsib Since Audacity 3.1 has been released, are you still interested in upstreaming the patches required to make looping back computer audio possible again?

crsib commented 2 years ago

I will upstream them, though I believe there will be a lengthy discussion about it because it can be a surprise to other PortAudio users. Generally - WASAPI interfaces count will be doubled. What's worse - loopback behaves slightly differently than a "normal" interface.