Closed BBArikL closed 2 years ago
Hi, sorry, you need to sign off our DCO before I can merge this.
Hi! Sorry, I had a put private email in my github profile, and did not change my primary email. Now that I have my good email now, I updated my sign to the DCO.
Did you force-push the commit to the same branch as the one you used for this pull request? Can't see it here, the checks are not passing either.
Oh on the commit itself? No I forked the repo, modified the file from Github and opened the pull request.... My commit should be marked as Verified by Github itself no? (Sorry, its the first time I do contributions to big projects).
That's fine, don't apologize! The verification says that you were the one that you made the commit. However, the "DCO" is like a signature that you leave in the bottom of a commit . The documents that you should generally glimpse through before submitting helpful contributions is CONTRIBUTING.md.
See the latest commit as an example: https://github.com/tenacityteam/tenacity/commit/0665614b85f1495c75fc1324d7bcead123009e91
In order to add that signature now, you would have to use git commit --amend
on your computer, with an installed version of Git, and then modify the commit message to add the "Signed-off-by: Name/Alias <contact@example.com>
" part
Hello! I just added what you wanted to the commit description! If there is anything else, let me know! :)
I will slightly modify the commit message because you also need to use the < >
around your e-mail. Just saying for future reference :)
Note to self: Add instructions for Debug binaries again later.
!. ATL/MFC components (v14.22) are not included by default in the C++ development kit, but are needed to compile the project.
Signed-off-by: BBArikL BBArik@protonmail.com
Resolves: (direct link to the issue) Precise steps to build the project faster. (short description of the changes and the motivation to make the changes)
Checklist
- [x] I have signed off my commits using `-s` or `Signed-off-by`\* (See: [Contributing § DCO](https://github.com/tenacityteam/tenacity/blob/master/CONTRIBUTING.md#developer-certificate-of-origin)) - [x] I made sure the code compiles on my machine - [x] I made sure there are no unnecessary changes in the code\* - [x] I made sure the title of the PR reflects the core meaning of the issue you are solving\* - [x] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"\* \* indicates required