tenacityteam / tenacity-legacy

THIS REPO IS NOT MAINTAINED ANYMORE. Please see https://codeberg.org/tenacityteam/tenacity for Tenacity, which is maintained.
https://tenacityaudio.org
Other
6.77k stars 256 forks source link

Precise build steps #688

Closed BBArikL closed 2 years ago

BBArikL commented 2 years ago

!. ATL/MFC components (v14.22) are not included by default in the C++ development kit, but are needed to compile the project.

  1. In Windows (not checked for linux distributions), cmake will build a Debug version of the software. Since cmake will check for information marked as "Release" to install the application by default (and not Debug), I think that it is fair to explicitly tell the persons who only want to install the project to build a "Release" version of the software.

Signed-off-by: BBArikL BBArik@protonmail.com

Resolves: (direct link to the issue) Precise steps to build the project faster. (short description of the changes and the motivation to make the changes)

Checklist - [x] I have signed off my commits using `-s` or `Signed-off-by`\* (See: [Contributing § DCO](https://github.com/tenacityteam/tenacity/blob/master/CONTRIBUTING.md#developer-certificate-of-origin)) - [x] I made sure the code compiles on my machine - [x] I made sure there are no unnecessary changes in the code\* - [x] I made sure the title of the PR reflects the core meaning of the issue you are solving\* - [x] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"\* \* indicates required
n0toose commented 2 years ago

Hi, sorry, you need to sign off our DCO before I can merge this.

BBArikL commented 2 years ago

Hi! Sorry, I had a put private email in my github profile, and did not change my primary email. Now that I have my good email now, I updated my sign to the DCO.

n0toose commented 2 years ago

Did you force-push the commit to the same branch as the one you used for this pull request? Can't see it here, the checks are not passing either.

BBArikL commented 2 years ago

Oh on the commit itself? No I forked the repo, modified the file from Github and opened the pull request.... My commit should be marked as Verified by Github itself no? (Sorry, its the first time I do contributions to big projects).

n0toose commented 2 years ago

That's fine, don't apologize! The verification says that you were the one that you made the commit. However, the "DCO" is like a signature that you leave in the bottom of a commit . The documents that you should generally glimpse through before submitting helpful contributions is CONTRIBUTING.md.

See the latest commit as an example: https://github.com/tenacityteam/tenacity/commit/0665614b85f1495c75fc1324d7bcead123009e91

In order to add that signature now, you would have to use git commit --amend on your computer, with an installed version of Git, and then modify the commit message to add the "Signed-off-by: Name/Alias <contact@example.com>" part

BBArikL commented 2 years ago

Hello! I just added what you wanted to the commit description! If there is anything else, let me know! :)

n0toose commented 2 years ago

I will slightly modify the commit message because you also need to use the < > around your e-mail. Just saying for future reference :)

n0toose commented 2 years ago

Note to self: Add instructions for Debug binaries again later.