n0toose
commented
2 years ago Merged, as the people normally managing this sort of stuff did not respond after two months of the pull request being both open and after a request went by without any feedback. Forgot to approve it first, but whatever, it's a fix for a problem in our setup that has plagued us for a while now and it works. The approval process was agreed on to specifically make sure that everyone would see a specific pull request and either veto or approve it before it went through when development was particularly intense, and I believe that we agreed that we would "loosen things up" if development were to die down.
Only real concern is the removal of the notarization stuff even if our build system can handle the absence of such variables, but I think that's alright for now.
Now the CodeQL CI build will use the zipped wx source code instead of cloning the git repo
Checklist
- [x] I have signed off my commits using `-s` or `Signed-off-by`\* (See: [Contributing § DCO](https://github.com/tenacityteam/tenacity/blob/master/CONTRIBUTING.md#developer-certificate-of-origin)) - [x] I made sure the code compiles on my machine - [x] I made sure there are no unnecessary changes in the code\* - [x] I made sure the title of the PR reflects the core meaning of the issue you are solving\* - [x] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"\* \* indicates required