search

tenacityteam / tenacity-legacy

THIS REPO IS NOT MAINTAINED ANYMORE. Please see https://codeberg.org/tenacityteam/tenacity for Tenacity, which is maintained.
https://tenacityaudio.org
Other
6.8k stars 262 forks source link

Update README.md #714

Open gregorylearns opened 2 years ago

gregorylearns commented 2 years ago

Add FossHub Link to download older Audacity versions to README.md took me a while to find audacity 3.0.2 there

Signed-off-by: Gregory degeemon@gmail.com

Resolves: (direct link to the issue)

(short description of the changes and the motivation to make the changes)

Checklist - [ ] I have signed off my commits using `-s` or `Signed-off-by`\* (See: [Contributing § DCO](https://github.com/tenacityteam/tenacity/blob/master/CONTRIBUTING.md#developer-certificate-of-origin)) - [ ] I made sure the code compiles on my machine - [ ] I made sure there are no unnecessary changes in the code\* - [ ] I made sure the title of the PR reflects the core meaning of the issue you are solving\* - [ ] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"\* \* indicates required
n0toose commented 2 years ago

Hi, thanks for your contribution. You kind of missed a space in between of your name and your email, but I don't think this is a big deal.

n0toose commented 2 years ago

Okay, now you're missing the < >'s :P

No worries! GitHub automatically removes them, so I understand why this is tricky. There's the --signoff parameter which makes this a whole lot easier when using the command line. You can also always use git log -p to check how previous commits look like.

n0toose commented 2 years ago

I would say that the quotation marks in what I said are a bit important, because this title kind of "violates" the proper flow of the sentence and the fact that the reader is reading a title is not immediately recognizable. It's a small fix, I can also do it myself if you don't feel like it, just trying to show how I'd do this myself around here.